Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logrus imports to github.com/sirupsen/logrus #160

Closed
ebracho opened this issue Jul 23, 2019 · 3 comments
Closed

Update logrus imports to github.com/sirupsen/logrus #160

ebracho opened this issue Jul 23, 2019 · 3 comments

Comments

@ebracho
Copy link

ebracho commented Jul 23, 2019

The logrus owner recently changed the case of their handle (Sirupsen -> sirupsen). This causes issues on case-insensitive filesystems (like in macos), since vendoring both versions of the package results in filepath collisions. The logrus maintainer has stated that they will keep the new name (see sirupsen/logrus#570), so it is up to other packages to update their imports.

@fxfactorial
Copy link

I am getting this issue as well:

 go build -o $GOPATH/bin/pd command/*
go: finding github.com/google/go-querystring/query latest
go: github.com/Sirupsen/logrus@v1.4.2: parsing go.mod: unexpected module path "github.com/sirupsen/logrus"
go: error loading module requirements

@stmcallister Can you please suggest a fix? I just want to just use pd service list

I looked at releases as well hoping that project would provide precompiled binaries (I need OS X) but it wasn't there either, i think that would be a good idea.

@stmcallister
Copy link
Contributor

Thanks for pointing this out! I'll take a look at this. But, it may not be until after the PagerDuty Summit conference next week.

@stmcallister
Copy link
Contributor

This was addressed with PR 168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants