Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IncidentDetails.Title field and mark IncidentDetails.Description as deprecated #277

Closed
theckman opened this issue Feb 20, 2021 · 1 comment · Fixed by #333
Closed
Milestone

Comments

@theckman
Copy link
Collaborator

Refer to this line of code:

Description string `json:"description"`

The PagerDuty V2 Webhooks documentation indicates that the description field is deprecated in-favor of the title field. We need to add a Title field to the struct, and add a comment above the Description field to indicate it's deprecated:

@theckman theckman added this to the v1.5.0 milestone Feb 20, 2021
@theckman
Copy link
Collaborator Author

Looks like I didn't scroll up. Title is already there, just needs a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant