Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting conference information in new incident #373

Closed
bparlidoordash opened this issue Oct 20, 2021 · 2 comments · Fixed by #391
Closed

Setting conference information in new incident #373

bparlidoordash opened this issue Oct 20, 2021 · 2 comments · Fixed by #391
Milestone

Comments

@bparlidoordash
Copy link

Hello, I'm looking to set the conference url and number when creating a new incident, however, I don't see a way to do that with this package? The API supports it, but not the CreateIncidentOptions type. And AFAICT the Incident type (which does have ConferenceBridge) is only used in responses from the API.

Am I overlooking something or would this be a feature request?

@theckman
Copy link
Collaborator

theckman commented Nov 9, 2021

This would be a feature request. 😄

If you had some time to add it to this CreateIncidentOptions struct, update the tests as needed, and open a PR, I'd greatly appreciate it. It's much for me to merge PRs of others than my own. 👍

go-pagerduty/incident.go

Lines 153 to 164 in ad98290

// CreateIncidentOptions is the structure used when POSTing to the CreateIncident API endpoint.
type CreateIncidentOptions struct {
Type string `json:"type"`
Title string `json:"title"`
Service *APIReference `json:"service"`
Priority *APIReference `json:"priority"`
Urgency string `json:"urgency,omitempty"`
IncidentKey string `json:"incident_key,omitempty"`
Body *APIDetails `json:"body,omitempty"`
EscalationPolicy *APIReference `json:"escalation_policy,omitempty"`
Assignments []Assignee `json:"assignments,omitempty"`
}

@bparlidoordash
Copy link
Author

Thank you @theckman! Looks like you already go to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants