Fix for go install
#436
Closed
Fix for go install
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inary named pd Signed-off-by: Michael Shen <mshen@redhat.com>
Signed-off-by: Michael Shen <mshen@redhat.com>
|
@theckman Not sure if you have cycles to review this - totally ok if you don't, but if I should ping someone else please let me know, thanks! |
|
Tagging @stmcallister - noticed that you've reviewed other PRs |
|
I think we need to figure out what we want to do with the command line tool. There's been a discussion in the past about this being removed from the project. I wonder if it makes sense to ask a PagerDuty employee to create a new repo, and migrate the code there so that it's go-getable. @stmcallister would that be something we could make happen? |
ChuckCrawford
added
the
open question
|
Subscribe. watching for Go 1.19 compatibility to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the contents of command into a
command/pdsubdirectory, go install can now be used to install a binary.I updated the README to demonstrate an example for latest, since the instructions won't work for v1.5.0, but maybe when the next version is released the example in the README can be pinned to a version?
Fixes #435