update documentation for pagerduty_extension #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
stmcallister
reviewed
Dec 5, 2019
| @@ -71,7 +71,8 @@ EOF | |||
| The following arguments are supported: | |||
|
|
|||
| * `name` - (Optional) The name of the service extension. | |||
| * `endpoint_url` - (Optional) The url of the extension. | |||
| * `endpoint_url` - (Reqeuired|Optional) The url of the extension. | |||
There was a problem hiding this comment.
Can you fix the spelling on Required here?
There was a problem hiding this comment.
What about leaving it Optional as that's how it is defined on the terraform schema, so terraform does not enforce it, but being more explicit about some exceptions for Generic V2 Webhook like described in https://github.com/terraform-providers/terraform-provider-pagerduty/issues/131#issuecomment-489375555 ?
There was a problem hiding this comment.
22cd0e6 fixed the typo @stmcallister
There was a problem hiding this comment.
I like the additional note! Nice job!
added 2 commits
December 7, 2019 04:34
stmcallister
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #131