Set Limit for /services GET to be at most 100 results #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ashmckenzie, huge thanks for this PR! pagination would indeed be nicer here, but for now this LGTM 👍 Thanks again! Best, |
heimweh
approved these changes
Sep 26, 2017
|
Hi @heimweh - any chance of a 0.1.3 release? Keen to see this plus the https://github.com/terraform-providers/terraform-provider-pagerduty/pull/38 GA 🙏 |
|
Note that this prevents importing services which are not returned in the first hundred page. I think I've got a better solution in https://github.com/terraform-providers/terraform-provider-pagerduty/pull/47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of services (75) in our PagerDuty account. I noticed when performing an
importI kept getting the error messageCould not locate a service ID for the integration.The root cause of the error was that the provider was only returning max 25 (default) services. I added a limit of 100 to the
/servicesGET. A more complete solution would be to correctly handling pagination however.