Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service integration importation when more than 100 services exist #47

Merged
merged 3 commits into from
Dec 4, 2017
Merged

Fix service integration importation when more than 100 services exist #47

merged 3 commits into from
Dec 4, 2017

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 23, 2017

Service integration importation failed with more than 100 services because the existing logic looped over the first hundred service to find a match.

Changing the importation logic to use an ID formed as service_id.integration_id resolves the issue.

This required updating the github.com/hashicorp/terraform/helper/resource dependency to v0.10.7 to get ImportStateIdFunc feature.

Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pdecat, huge thanks for this. This LGTM 👍

@heimweh heimweh merged commit 5fb17ee into PagerDuty:master Dec 4, 2017
@pdecat pdecat deleted the f-fix-service-integration-import branch July 10, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants