Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need deg2rad for input arguments in degrees ° #458

Closed
JeffFessler opened this issue Jun 26, 2021 · 0 comments
Closed

Need deg2rad for input arguments in degrees ° #458

JeffFessler opened this issue Jun 26, 2021 · 0 comments

Comments

@JeffFessler
Copy link
Contributor

Currently the Base.deg2rad produces wrong output "units" when input is of type Degree:

using Unitful
angle = 90u"°"
deg2rad(angle)

1.5707963267948966°

(Notice the degree symbol at the end.)
I propose something similar to how cos is handled:

deg2rad(d::Quantity{T, NoDims, typeof(Unitful.°)}) where {T} =
    deg2rad(ustrip(d)) * 1u"rad"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeffFessler