Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report #513

Closed
nishant3721 opened this issue Feb 26, 2023 · 12 comments · Fixed by #516
Closed

Bug Report #513

nishant3721 opened this issue Feb 26, 2023 · 12 comments · Fixed by #516
Assignees

Comments

@nishant3721
Copy link
Contributor

Describe the bug
The screen stays on creating organization modal after the organization is created

To Reproduce
Steps to reproduce the behavior:

  1. signup/login
  2. treat yourself as SUPERADMIN
  3. Click on the button Create Organization
  4. Simply create the new organization

Expected behavior
When an organization is created, the modal should ideally be closed and it should be navigated to the manage oranizations section.

Actual behavior
The screen stays on creating organization modal after the organization is created

Screenshots
image

Additional details
Not required

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@nishant3721 nishant3721 added the bug Something isn't working label Feb 26, 2023
@github-actions
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@nishant3721
Copy link
Contributor Author

nishant3721 commented Feb 26, 2023

@palisadoes I would like to work on it, also please review this issue on your end, is it a valid issue or not!?

@aashimawadhwa
Copy link
Member

I cannot see this issue on my system is it so for you @xoldyckk .

@rishav-jha-mech
Copy link
Contributor

@aashimawadhwa i also noticed this issue, when you successfully create an organisation, you will be shown a toast and then the createOrganisation form in modal will become empty and you have to manually close it by clicking on the cross button.

I suggest it would be better if the modal is closed once the organisation is created.

@nishant3721
Copy link
Contributor Author

@rishav-jha-mech Absolutely right

@xoldd
Copy link

xoldd commented Feb 26, 2023

I cannot see this issue on my system is it so for you @xoldyckk .

It's not a bug. It's a UI behaviour. You can choose what you want to do after an organization is created.

@nishant3721
Copy link
Contributor Author

@xoldyckk wouldn't it be better if modal closed after creating an organisation successfully, such that it will be more friendly to the user!?

@xoldd
Copy link

xoldd commented Feb 26, 2023

@xoldyckk wouldn't it be better if modal closed after creating an organisation successfully, such that it will be more friendly to the user!?

Yeah it will be more user friendly, but only if the user is on the organization list page when creating the organization. If user is on some other page, and there's still the option to create organization, and you reroute them back to organization list page on creation then it's bad.

@nishant3721
Copy link
Contributor Author

@xoldyckk Then, the modal should be closed simply, If the user is on the organisation list page then, creating an organisation will be routed back to the list page, in other cases it would stay on that page even after creating the modal.

@xoldd
Copy link

xoldd commented Feb 26, 2023

@xoldyckk Then, the modal should be closed simply, If the user is on the organisation list page then, creating an organisation will be routed back to the list page, in other cases it would stay on that page even after creating the modal.

Yeah. So, you want to get assigned for this?

@palisadoes
Copy link
Contributor

On what other page besides the organization list page can creating an organization be done?

@nishant3721
Copy link
Contributor Author

@xoldyckk Then, the modal should be closed simply, If the user is on the organisation list page then, creating an organisation will be routed back to the list page, in other cases it would stay on that page even after creating the modal.

Yeah. So, you want to get assigned for this?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants