Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD : Check for Starting a Server. #1343

Closed
kb-0311 opened this issue Jun 4, 2023 · 29 comments · Fixed by #1371
Closed

CI/CD : Check for Starting a Server. #1343

kb-0311 opened this issue Jun 4, 2023 · 29 comments · Fixed by #1371
Assignees
Labels

Comments

@kb-0311
Copy link
Contributor

kb-0311 commented Jun 4, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.

For PR workflow under talawa-api repository, there should be a job that checks whether the development server starts successfully or not.

Describe the solution you'd like
A clear and concise description of what you want to happen.

A job that checks whether the apollo server can start or not.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Approach to be followed (optional)
A clear and concise description of approach to be followed.

Additional context
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@kb-0311
Copy link
Contributor Author

kb-0311 commented Jun 9, 2023

@palisadoes Did not realize I was assigned this issue. Unassigning myself, for now, to let newer contributors get a chance. If the issue becomes stale, tag me here.

Please do put the good first issue as a label on this one.

@kb-0311 kb-0311 removed their assignment Jun 9, 2023
@palisadoes palisadoes added the good first issue Good for newcomers label Jun 11, 2023
@Shub3am
Copy link

Shub3am commented Jun 21, 2023

Hey, Is this issue assigned?

@kb-0311
Copy link
Contributor Author

kb-0311 commented Jun 21, 2023

@Shub3am no it is not, You can ask for an assignment.

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Jun 21, 2023
@Shub3am
Copy link

Shub3am commented Jun 22, 2023

@kb-0311 Can i get some guidance on this issue?

@Shub3am Shub3am removed their assignment Jun 22, 2023
@kb-0311
Copy link
Contributor Author

kb-0311 commented Jun 22, 2023

@Shub3am Sure, so basically the idea of this CI/CD check is to make sure that the Apollo server with the given schema at that point can be started. No need to create all the specifications for that complete server which will require a lot of env variables to be defined in the GitHub action but rather try to create a mock Apollo server which has only the basics of the actual talawa-api apollo server defined as specs like schema , context , format error etc.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jul 3, 2023
@ishtails
Copy link
Contributor

ishtails commented Aug 3, 2023

can this issue be assigned to me?

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 15, 2023
@palisadoes palisadoes reopened this Aug 22, 2023
@palisadoes
Copy link
Contributor

Reopening due to a syntax error in the PR.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 23, 2023
@ishtails
Copy link
Contributor

ishtails commented Aug 25, 2023

hey there, sorry for the inconvenience. I'll fix the errors and make a PR

@ishtails ishtails mentioned this issue Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Sep 5, 2023
@aarishshahmohsin
Copy link

My pr has a lot of errors. I think someone else should solve it.
@palisadoes

@aarishshahmohsin aarishshahmohsin removed their assignment Dec 4, 2023
@adi790uu
Copy link
Contributor

adi790uu commented Dec 9, 2023

Hey @noman2002 @xoldyckk would like to work on this

@MikiPAUL
Copy link

MikiPAUL commented Dec 12, 2023

Hey @noman2002, Please assign this issue to me.

@noman2002
Copy link
Member

@adi790uu Let him work on this one. As he is new here.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 24, 2023
@palisadoes
Copy link
Contributor

Unassigning due to inactivity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 2, 2024
@shankeleven
Copy link

shankeleven commented Jan 5, 2024

Please assign the issue to me, would be glad to work @palisadoes

@Veer0x1
Copy link
Contributor

Veer0x1 commented Jan 6, 2024

I would like to work on this issue.

@shankeleven
Copy link

shankeleven commented Jan 9, 2024

sir, in this issue do i have to just write a job in workflow for running some already existing tests(npm run test) or do i have to write a test file for sending queries to graphl server and validating responses?

@kb-0311
Copy link
Contributor Author

kb-0311 commented Jan 9, 2024

@shankeleven you first have to write a test file for the same and then execute it in the workflow as a check.

@shahzamaahmad
Copy link

How can i contribute

@Cioppolo14
Copy link
Contributor

@shahzamaahmad Please look through the unassigned issues in our repositories, and find one that fits your skill set. Comment on an unassigned issue that you feel you can complete, and mention that you'd like to work on it. Please make sure to review this page: https://github.com/PalisadoesFoundation, and the important documents in each repo before contributing to that repo. Thank you for wanting to contribute!

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 29, 2024
@dhruvgupta0503
Copy link

I can work on this issue pls assign it to me

@Cioppolo14
Copy link
Contributor

@dhruvgupta0503 If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet