Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/resolvers/middleware/currentUserExists.ts #1818

Closed
palisadoes opened this issue Feb 8, 2024 · 9 comments
Closed

Test: src/resolvers/middleware/currentUserExists.ts #1818

palisadoes opened this issue Feb 8, 2024 · 9 comments
Assignees
Labels
feature request parent Parent issue test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  1. Tests need to be written for file src/resolvers/middleware/currentUserExists.ts
  2. We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  3. When complete, all all methods, classes and/or functions in the refactored file will need to be tested.
  4. These tests must be placed in a single file with the same path as the tested file, but under the tests/ with a .spec.ts suffix.
  5. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.

Other

Please coordinate issue assignment and PR reviews with the contributors listed in this issue:

@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Feb 8, 2024
@NayOoLwin5
Copy link

I would like to work on this issue

@Cioppolo14
Copy link
Contributor

@NayOoLwin5 You now have two issues. Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@MahendraDani
Copy link
Contributor

@Cioppolo14 I would like to work on this issue

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Feb 10, 2024
@MahendraDani
Copy link
Contributor

Is there a command to run test on specified only instead of all the files?

@MahendraDani
Copy link
Contributor

I could not write the tests, my apologies.

@MahendraDani MahendraDani removed their assignment Feb 26, 2024
@aarishshahmohsin
Copy link

Can I be assigned this issue?

@Olatade
Copy link

Olatade commented Feb 26, 2024

@aarishshahmohsin
Our policy is to assign no more than one issue to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@Sivam2313
Copy link

I would like to work on this issue

@Cioppolo14
Copy link
Contributor

@aarishshahmohsin I am going to assign you this issue, I only see that you have one issue. I think we had some confusion, you are allowed a maximum of 2 issues across all repositories with a few exceptions. Thank you for your understanding, we are working hard to keep the flow going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request parent Parent issue test Testing application
Projects
None yet
Development

No branches or pull requests

7 participants