Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvers: Create Tests for reuploadDuplicateCheck.ts #795

Closed
SiddheshKukade opened this issue Dec 5, 2022 · 9 comments
Closed

Resolvers: Create Tests for reuploadDuplicateCheck.ts #795

SiddheshKukade opened this issue Dec 5, 2022 · 9 comments
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@SiddheshKukade
Copy link
Member

SiddheshKukade commented Dec 5, 2022

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/utilities/reuploadDuplicateCheck.ts

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/utilities/ReuploadDuplicateCheck.spec.js. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
@SiddheshKukade SiddheshKukade added feature request unapproved Unapproved for Pull Request points 01 test Testing application and removed feature request labels Dec 5, 2022
@github-actions github-actions bot added the parent Parent issue label Dec 5, 2022
@SiddheshKukade SiddheshKukade added good first issue Good for newcomers and removed parent Parent issue labels Dec 5, 2022
@TheLazron
Copy link

Can I be assigned this issue, would like to work on it

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Jan 14, 2023
@palisadoes palisadoes changed the title Resolvers: Create Tests for ReuploadDuplicateCheck.js Resolvers: Create Tests for reuploadDuplicateCheck.ts Jan 24, 2023
@palisadoes
Copy link
Contributor

@TheLazron Are you still working on this? The issue has been updated to reflect that the file is .ts

@kb-0311
Copy link
Contributor

kb-0311 commented Jan 25, 2023

pls assign it to me

@palisadoes
Copy link
Contributor

@kb-0311
Copy link
Contributor

kb-0311 commented Jan 25, 2023

@palisadoes Sir , what do you mean by 'coordinate issue assignment ' with them? Like ping them personally or tag them in the issue assignment comment under an issue?

@palisadoes
Copy link
Contributor

Yes. They have volunteered to assist me with this. The workload was getting too great for me alone.

@noman2002
Copy link
Member

@TheLazron are you still working on this ??

@SiddheshKukade
Copy link
Member Author

@noman2002 It's been 2 weeks since @TheLazron is working on this. I would like to take this up. you can assign to me

@kb-0311
Copy link
Contributor

kb-0311 commented Feb 1, 2023

@SiddheshKukade This is a duplicate Issue , same as #887 for which I was assigned.

I have already made a PR for this file #963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

No branches or pull requests

5 participants