Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/resolvers/Subscription/messageSentToGroupChat.ts #889

Closed
palisadoes opened this issue Jan 24, 2023 · 8 comments · Fixed by #1113
Closed

Test: src/lib/resolvers/Subscription/messageSentToGroupChat.ts #889

palisadoes opened this issue Jan 24, 2023 · 8 comments · Fixed by #1113
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/resolvers/Subscription/messageSentToGroupChat.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/resolvers/Subscription/messageSentToGroupChat.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the test Testing application label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes added good first issue Good for newcomers points 01 and removed parent Parent issue labels Jan 24, 2023
@kb-0311
Copy link
Contributor

kb-0311 commented Jan 29, 2023

pls assign this to me

@aviraldevv
Copy link
Contributor

I am also open to work on this issue.

@palisadoes
Copy link
Contributor Author

@kb-0311 Please check slack

@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Jan 29, 2023
@aviraldevv aviraldevv removed their assignment Feb 3, 2023
@aviraldevv
Copy link
Contributor

I am unassigning this issue for the time being if it is not resolved by someone else I'll come back to it.

@pinkman7009
Copy link

Hi, can you please assign this issue to me? @aviraldevv @palisadoes

@noman2002
Copy link
Member

@pinkman7009 Any update ?

@palisadoes
Copy link
Contributor Author

Unassigning so that others can get a chance.

@KrutikaBhatt
Copy link
Contributor

@palisadoes, can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
6 participants