Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/resolvers/Subscription/index.ts #891

Closed
palisadoes opened this issue Jan 24, 2023 · 10 comments
Closed

Test: src/lib/resolvers/Subscription/index.ts #891

palisadoes opened this issue Jan 24, 2023 · 10 comments
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/resolvers/Subscription/index.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/resolvers/Subscription/index.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes added good first issue Good for newcomers points 01 and removed bug Something isn't working parent Parent issue labels Jan 24, 2023
@kunxl-gg
Copy link

can I work on this issue

@noman2002 noman2002 removed the unapproved Unapproved for Pull Request label Jan 28, 2023
@noman2002
Copy link
Member

Sure, assigned it to you.

@nishant3721
Copy link
Contributor

nishant3721 commented Jan 29, 2023

@noman2002 I have already written the test for it? can you assign it to me?

@anshgoyalevil
Copy link
Contributor

@noman2002 I have written the tests for this file. Can I be assigned to this issue. The test is covering 100% of src/lib/resolvers/Subscription/index.ts file.

@noman2002
Copy link
Member

@nishant3721 @anshgoyalevil Please follow the procedure. It can't be assigned to you guys because someone is already working on this issue. Please take other issues.
@anshgoyalevil You already have 3 issues assigned to you please get the PR merged for all of them before asking for more issues. Thank you.

@anshgoyalevil
Copy link
Contributor

@nishant3721 @anshgoyalevil Please follow the procedure. It can't be assigned to you guys because someone is already working on this issue. Please take other issues. @anshgoyalevil You already have 3 issues assigned to you please get the PR merged for all of them before asking for more issues. Thank you.

Sure Sir. Thanks

@aviraldevv
Copy link
Contributor

@Kunal-GG are you still working on this issue?

@kunxl-gg
Copy link

@Kunal-GG are you still working on this issue?

Yes. I have done some work. I had few exams this week that is why got a little busy. Will probably make a PR by tomorrow or day after max.

@aviraldevv
Copy link
Contributor

It's totally fine @Kunal-GG take your time.

@palisadoes
Copy link
Contributor Author

Closing as this is not best practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

No branches or pull requests

6 participants