Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/libraries/logger.ts #915

Closed
palisadoes opened this issue Jan 24, 2023 · 29 comments
Closed

Test: src/lib/libraries/logger.ts #915

palisadoes opened this issue Jan 24, 2023 · 29 comments
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/libraries/logger.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/libraries/logger.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes removed bug Something isn't working parent Parent issue labels Jan 24, 2023
@KrutikaBhatt
Copy link
Contributor

Hey @palisadoes, can I solve this issue?
I have read through the documentation and contribution guidelines. I will make sure to follow those guidelines.

@frey0-0
Copy link
Contributor

frey0-0 commented Feb 5, 2023

is this issue still open? If yes I would like to work on it @palisadoes :)

@palisadoes
Copy link
Contributor Author

  1. Please refer to Tests for src/lib/libraries/logger.ts #951
  2. We would like the tests to reach 100% code coverage

@KrutikaBhatt
Copy link
Contributor

Hey @frey0-0, here are certain resources and blogs that I found useful and might help you to understand.

  1. Winston logger documentation
  2. Unit testing for logger in jest
  3. A guide to winston logging
  4. You can also check out the usage of winston spy here - Wiston-Spy

Hope this helps!

@noman2002
Copy link
Member

@frey0-0 Any update on this one ??

@palisadoes
Copy link
Contributor Author

Unassigning.

@arunavabasucom
Copy link
Contributor

Can I work on this ?

@palisadoes
Copy link
Contributor Author

@arunavabasu-03 You already have 2 issues assigned

@arunavabasucom
Copy link
Contributor

I think @palisadoes sir , one of those issue got merged!!

@palisadoes
Copy link
Contributor Author

We reopened the issue as coverage isn't 100%

@arunavabasucom
Copy link
Contributor

Actually sir , #913 is going to take longer time so i uassign to me , can you assign me this one !!

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 7, 2023
@lata-11
Copy link

lata-11 commented Mar 9, 2023

Hey! If this issue is not resolved yet. Can you assign me?

@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 21, 2023
@Ladyperpetua
Copy link

@palisadoes can i please be assigned this issue?

@Ladyperpetua
Copy link

Thank you sir @palisadoes . on it

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 3, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Apr 4, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Apr 15, 2023
@github-actions
Copy link

This issue did not get any activity in the past 180 days and thus has been closed. Please check if the newest release or develop branch has it fixed. Please, create a new issue if the issue is not fixed.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
@palisadoes palisadoes reopened this Oct 18, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Oct 19, 2023
@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 29, 2023
@Tweniee
Copy link

Tweniee commented Nov 20, 2023

@palisadoes can you tell me whats pending in this issue,
as i can see someone already merged the PR related to this issue

@palisadoes
Copy link
Contributor Author

The file does not have 100% code coverage as mentioned in the issue's initial comment.

@aashimawadhwa will be handling all issue queries and seeking reviewers for PRs. When necessary, this contributor will contact other contributors who will be able to assist. Please ask them for guidance on your future questions.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 21, 2023
@aarishshahmohsin
Copy link

Can I be assigned this issue?

@lakshz
Copy link
Contributor

lakshz commented Nov 27, 2023

Is this issue open? I can find tests/libraries/logger.spec.ts already on the develop branch.
If it's open, I want to work on this. Please assign it to me

@aarishshahmohsin
Copy link

I'm unassigning myself from this issue as I couldn't find a solution. I appreciate your understanding.

@aarishshahmohsin aarishshahmohsin removed their assignment Dec 1, 2023
@palisadoes
Copy link
Contributor Author

This issue has been attempted multiple times without success. Getting 100% coverage may not be possible.

@Tweniee
Copy link

Tweniee commented Dec 2, 2023

I want to try just need a bit guidance about the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

No branches or pull requests

10 participants