Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/lib/directives/authDirective.ts #920

Closed
palisadoes opened this issue Jan 24, 2023 · 9 comments · Fixed by #1013
Closed

Test: src/lib/directives/authDirective.ts #920

palisadoes opened this issue Jan 24, 2023 · 9 comments · Fixed by #1013
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Jan 24, 2023

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  • Tests need to be written for file src/lib/directives/authDirective.ts
  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a
    single file with the name __tests__/directives/authDirective.spec.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.
@palisadoes palisadoes added the bug Something isn't working label Jan 24, 2023
@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Jan 24, 2023
@palisadoes palisadoes removed bug Something isn't working parent Parent issue labels Jan 24, 2023
@parteekcoder
Copy link

@palisadoes could you please assign me this issue

@palisadoes
Copy link
Contributor Author

@noman2002
Copy link
Member

@parteekcoder You can work on this. Assigned to you.

@anshgoyalevil
Copy link
Contributor

@parteekcoder are you still working on this issue?

@anshgoyalevil
Copy link
Contributor

@palisadoes Could you please assign this issue to me.

@palisadoes
Copy link
Contributor Author

@parteekcoder we'll reassign this after a week of no activity.

@noman2002 noman2002 added the unapproved Unapproved for Pull Request label Feb 5, 2023
@noman2002
Copy link
Member

Unassigned due to inactivity.

@anshgoyalevil
Copy link
Contributor

anshgoyalevil commented Feb 5, 2023

@palisadoes Please assign this to me.

@KrutikaBhatt
Copy link
Contributor

@palisadoes, can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants