Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Mutation/createEventProject #878

Merged

Conversation

Kunal4now
Copy link
Contributor

@Kunal4now Kunal4now commented Jan 21, 2023

What kind of change does this PR introduce?

Add tests for Mutation/createEventProject.ts

Issue Number:

Fixes #879

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Merging #878 (7cc91e2) into develop (3bed52a) will increase coverage by 0.78%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #878      +/-   ##
===========================================
+ Coverage    82.01%   82.79%   +0.78%     
===========================================
  Files          168      168              
  Lines        10087    10087              
  Branches       869      882      +13     
===========================================
+ Hits          8273     8352      +79     
+ Misses        1812     1733      -79     
  Partials         2        2              
Impacted Files Coverage Δ
src/resolvers/Mutation/createEventProject.ts 100.00% <0.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@palisadoes
Copy link
Contributor

Good work. Please try to see how you can get the code coverage up to 100%

@SiddheshKukade
Copy link
Member

I can't find any issue linked and assigned for this PR.

@Kunal4now
Copy link
Contributor Author

I've created an issue and linked it to this PR.

@palisadoes
Copy link
Contributor

@Kunal4now the process is to create the issue first and get it assigned. This way we don't have multiple people duplicating efforts. It greatly helps with management. Please ask to get assigned to the issue you created.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kunal4now the process is to create the issue first and get it assigned. This way we don't have multiple people duplicating efforts. It greatly helps with management. Please ask to get assigned to the issue you created.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to get the code coverage to 100% for the file you have made changes.

@Kunal4now Kunal4now requested review from noman2002 and removed request for DMills27 and SiddheshKukade January 26, 2023 15:55
@palisadoes palisadoes merged commit a33e716 into PalisadoesFoundation:develop Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolvers: Create tests for src/lib/resolvers/Mutation/createEventProject.ts
5 participants