Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for tests/utilities/reuploadDuplicateCheck.spec.ts #963

Merged
merged 2 commits into from
Feb 2, 2023
Merged

tests for tests/utilities/reuploadDuplicateCheck.spec.ts #963

merged 2 commits into from
Feb 2, 2023

Conversation

kb-0311
Copy link
Contributor

@kb-0311 kb-0311 commented Feb 1, 2023

What kind of change does this PR introduce?

Issue Number:

Fixes #887

Did you add tests for your changes?
Yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

No.
Other information

Have you read the contributing guide?
Yes

@kb-0311
Copy link
Contributor Author

kb-0311 commented Feb 1, 2023

Same issue as #795 so after this one is merged pls close that issue also

@kb-0311
Copy link
Contributor Author

kb-0311 commented Feb 1, 2023

I don't understand why the test is failing even though it was passing just a few minutes ago? @palisadoes

@kb-0311
Copy link
Contributor Author

kb-0311 commented Feb 1, 2023

could you rerun the tests?

@kb-0311
Copy link
Contributor Author

kb-0311 commented Feb 1, 2023

Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

Is the error

@codecov-commenter
Copy link

Codecov Report

Merging #963 (6dd92cd) into develop (7cf19d1) will increase coverage by 0.18%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #963      +/-   ##
===========================================
+ Coverage    93.23%   93.42%   +0.18%     
===========================================
  Files          168      168              
  Lines        10101    10101              
  Branches       998     1001       +3     
===========================================
+ Hits          9418     9437      +19     
+ Misses         683      664      -19     
Impacted Files Coverage Δ
src/utilities/reuploadDuplicateCheck.ts 100.00% <0.00%> (+31.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@palisadoes
Copy link
Contributor

@noman2002 Please review and merge if OK

@noman2002
Copy link
Member

@noman2002 Please review and merge if OK

Don't have access to merge.

@palisadoes palisadoes merged commit 5e37a35 into PalisadoesFoundation:develop Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: src/lib/utilities/reuploadDuplicateCheck.ts
4 participants