-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: ControlNet does nothing #55
Comments
I did some updates for some compatibility with newer controlnet on dev, but it may cause that issue. If you try an older commit You can return to latest commit with The changes are pretty minor, so not sure if it would affect it. |
Wait, checking the log, it said this:
OpenPose comes from another extension without the need of a model? (Sorry, I'm really novice with controlnet) |
Sorry for my novice question, but does open pose needs a model or it works just like that? |
Yes! I haven't used openpose before, so I'm not sure how it works. |
This isn't specifically for OpenPose, but for ControlNet in general. If you input an image you can preprocess it using a model like for example OpenPose. I already provided a pose as an image so I don't have to preprocess it anymore that's why I leave it as "None". |
Oh I see. If you select openpose on preprocessor and none in model, it gets the same issue? Also, did this work before today commits? |
I will try using the older commit you wanted me to checkout. |
I get the same error
|
Okay, can you go back to the commit that worked for you yesterday? You can go to https://github.com/Panchovix/stable-diffusion-webui-reForge/commits/dev_upstream, search the commit, press it and inside, below "browse files" at the right, there is a "commit" do "git checkout hash" replacing hash with the value there, and let me know if it works as expected. Also please let me know what commit/hash was the working one. |
I am utterly confused. I can't get it to work at all anymore. Everything I try with preprocessor on throws this error: Doesn't even generate an image with preprocessor turned on... |
That is pretty weird, if it worked before. Can you try main branch and see if it works there? If not, then remaining test would be stock forge (aka using this commit bfee03d, with |
I tried it on my separate forge install and I get the same error there too? |
Hmm if it on stock forge happens, then it would probably happen here as well. Pretty weird by what you explain about it though. If you have a separate A1111 install, does it work there? (A1111 uses the updated controlnet extension though, so it differs, but it's to test) |
Alright I don't know what I did but I am back where I started with reForge. Same error as I first had. On A1111 it works fine. |
Okay, thanks. I think it isn't a bug with some updates but a bug at how Forge does openpose, if I'm not wrong. |
I also found out that the Preprocessor and Model are separate. You are supposed to always select a model (makes sense I was just stupid), but you can leave the Preprocessor as "None". It doesn't work in reForge/forge either way though. |
I just downloaded and tested a model and it seems to work? It is done like this?
|
Gimme a minute. I have a mission now:
|
I downloaded an openpose model and then it worked, even if not setting pre processor, but I had to choose a model yes or yes, else I would get a no error model (I guess that's forge behavior
|
I reinstalled everything completely from scratch and I still get an error... I might just give up and learn comfyui at this point 😭 |
It was the model. The model did not work. Using a different model fixed it. I'm gonna go burry myself now. So any "control lllite" model from kohya throws an error. |
Does it happen because control lllite models are not implemented in the reForge ControlNet extension maybe? |
Oh haha, well, glad you found the culprit for this case. I have to check the no model loaded thing, I think when I have enough time will check how A1111 implements it and see how it works. About the model, I think it supports normal controllite, but I guess it doesn't support controllllite, probably it's missing updates. I will try to check and understand how it works, and update accordingly. I think saw some comfy nodes doing this. Closing the issue for now. |
Okay so this issue happens with stock forge as well? (Same error?) |
Already turned off my PC because I'm gonna sleep now. I am pretty sure it was the same error. You can probably reproduce it yourself though if you use any kohya control lllite model from here: http://huggingface.co/lllyasviel/sd_control_collection/tree/main |
Thanks, gonna see if I can manage to get something today. |
Okay found and it seems it's an issue with control net lite itself. kohya-ss/ControlNet-LLLite-ComfyUI#8
Tested with those resolution and it works. Probably A1111 has some fixes related to this. For comfy you need a extra node from an extension.
Will research how to fix when I have time, since it seems to be not trivial, but at least we know it should work. |
Hi Panchovix, I wrote that comment you quoted with the list of working resolutions and non-working resolutions. You've probably figured this out by now but just in case I found the common denominator... literally. It's 64. All of the resolutions that work are multiples of 64 and the ones that don't are not. I've tested several other odd-ball resolutions and they all work if they are multiples of 64 and don't otherwise. Hope this helps. |
Checklist
What happened?
Idk what happened, but ControlNet doesn't seem to do anything anymore? Even with full strength the ControlNet model doesn't influence the pose at all.
Steps to reproduce the problem
What should have happened?
ControlNet influences the outcome of the image.
What browsers do you use to access the UI ?
Brave
Sysinfo
sysinfo-2024-07-22-20-15.json
Console logs
Additional information
I updated the WebUI today so maybe it was a change that broke it?
The text was updated successfully, but these errors were encountered: