Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with older versions of a vanilla minecraft server (tested with 1.12.2) #39

Closed
MrPixelized opened this issue Dec 22, 2023 · 5 comments

Comments

@MrPixelized
Copy link

Trying to use a type = "vanilla" [jar] section with mc_version = "1.12.2" leads to the following error on running mcman build:

Error: Resolving Vanilla

Caused by:
    0: error decoding response body: missing field `name` at line 1 column 11698
    1: missing field `name` at line 1 column 11698

I've gotten around this by instead using:

[jar]
type = "url"
url = "https://piston-data.mojang.com/v1/objects/886945bfb2b978778c3a0288fd7fab09d315b25f/server.jar"

Which works, but also means that I have to manually edit the EULA file before starting the server.

It's nice that the system is flexible enough to support this fix, but the whole situation leads to two things:

  • This bug report (of the issue with vanilla servers)
  • A feature request: custom build hooks (I could add a hook that simply performs echo "eula=true" > eula.txt
@TheAlan404
Copy link
Contributor

Oh, I think I know how to fix this. Expect it fixed in 0.4.3

About the build hooks - I was already planning on something like this but a massive issue with it is platform independency - Windows and Linux shells are greatly different...

@TheAlan404
Copy link
Contributor

Hold on a second, why didn't you put an eula.txt under the config directory? It'll get copied to server?

@MrPixelized
Copy link
Author

I just didn't think of it! But regardless, these build hooks would be quite nice. I think platform independency isn't that hard, just execute a file directly. On linux, the desired program (whether it be shell language or anything else) can be set using the shebang, and on windows you can use links or binaries.

@TheAlan404
Copy link
Contributor

TheAlan404 commented Dec 22, 2023

How would the config for that work? Could you provide any examples if you can think of any? Thanks!

edit: I think creating an issue for this would be better

@MrPixelized
Copy link
Author

#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants