Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates /obj/item/storage/part_replacer to the new attack chain (and fixes false positive exploit logging) #28220

Closed
wants to merge 1 commit into from

Conversation

Fordoxia
Copy link
Contributor

@Fordoxia Fordoxia commented Feb 2, 2025

What Does This PR Do

Migrates /obj/item/storage/part_replacer to the new attack chain.

Admins are no longer messaged about an exploit attempt just because a machine has no stock parts.

No player-facing changes.

Why It's Good For The Game

Attack chain migration good.

False positive log is bad.

Testing

Used RPED and BRPED on machinery in proximity and far away, screwed and unscrewed, to verify proper functionality.

Ensured that the exploit alert only triggered when I was actually trying to shoot machines through a camera console that I couldn't already see with my own eyeballs.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 2, 2025
@warriorstar-orion warriorstar-orion added the Attack Chain Migration Refactoring of legacy attack chain items label Feb 2, 2025
Copy link
Contributor

@warriorstar-orion warriorstar-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a handful of machines that do an istype check for part replacers in their item_interaction procs, could you do a quick pass through those and remove them?

@Fordoxia Fordoxia closed this Feb 2, 2025
@Fordoxia
Copy link
Contributor Author

Fordoxia commented Feb 2, 2025

Closed because of requirement to migrate all of storage. Warriorstar has a draft for this.

@Fordoxia Fordoxia deleted the BRPD branch February 3, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Attack Chain Migration Refactoring of legacy attack chain items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants