Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meet the Smith - New Supply Role #28273

Draft
wants to merge 39 commits into
base: master
Choose a base branch
from

Conversation

PollardTheDragon
Copy link
Contributor

@PollardTheDragon PollardTheDragon commented Feb 6, 2025

What Does This PR Do

Adds the Smith, a new role in the supply department. They have two alternative titles - Metalworker and Tinkerer. They have 1 slot open roundstart.

Their job is to use a slew of new machines to refine ores more efficiently than the ORM, as well as produce customizable modifications for suit slot items, tools, and energy guns. They have two locations specific to them - an office on each station where they start and where they can distribute their wares, and a workshop at the lavaland base.

The main gameplay loop of the smith involves routine visits to and from lavaland to deliver mineral sheets to the ORM. Their SOP should contain a clause saying that they must deliver mineral sheets to the ORM within a given time. Likewise, on lavaland, they can use casts, along with the new machines, to create modifications which they can sell or distribute.

The new machines are as follows:

  • Smart Hopper: It takes ore similar to an ORM and puts them in a magma crucible to be refined. Awards points to miners.
  • Magma Crucible: Huge 3x3 machine that melts ores inserted into it.
  • Casting Basin: A machine that can take a mold and use it to receive sheets from the magma crucible, or create raw components from the materials within the crucible.
  • Power Hammer: A large 2x2 machine that can take a heated component and shape it.
  • Lava Furnace: A large 2x2 machine that can take a cooled component and heat it.
  • Kinetic Assembler: A machine that takes three components and combines them into an item mod.
    All machines are upgradable. Upgrading the hopper increases point payouts. Upgrading the crucible increases the amount of sheets per ore. Upgrading the basin increases the efficiency of creating components. All other machines receive increased speed. All machines are buildable on station, in the event that the lavaland base is trashed by megafauna.

To accompany the smith, three new ores are added to space rocks that are worth as many points as a diamond, and are needed to create the most advanced of their items. Platinum, Palladium, and Iridium can now be found in space rocks.

All modifications have a material - determined by the trim - and a quality - determined from the lowest quality of the assembled parts. Qualities are not random - when making a component from a mold, you select a quality. Higher qualities require more work time and more materials, but increase the statistics of a modification. Materials have benefits and drawbacks for each material used, modifying the final stats of the item prior to quality being assigned.

The smith also adds a new tool - the hammer. Currently, the only use of the hammer is to complete the crafting of a modification at a Kinetic Assembler, however they can be used as a basic weapon in a pinch (10 brute). The smith starts with three in their office, alongside a toolbelt, EFTPOS, and locker.

Suit clothing gains a slot for insert modifications. Energy guns gain a slot for a lense. Tools gain a slot for a tool bit. Head of staff suits gain 2 slots for inserts. Captain, QM, and Smith suits gain 3 slots for inserts.

To fit the new office in, supply maps have undergone changes on all maps, and the lavaland outpost has a new branch entirely for the smith's workshop.

Why It's Good For The Game

Adds a new role that replaces a simple, automatic machine with an entire gameplay loop that players may enjoy. Adds departmental content to Supply that is more than just new ruins or gamer loot. It also adds another thing for explorers to do - retrieving rare space ores - that deviates from the current go-to for playing explorer (hunting for gamer loot in ruins).

TODO

  • Finish operational code for the hopper and magma crucible
  • Sprites for everything
  • Role clothing
  • Molds
  • Sprites for everything
  • TGUI menu for the magma crucible
  • Test the hell out of it

Images of changes

Images pending - sprites

Testing

TODO. Some of this is tested, but the full loop isn't as the molds aren't ready yet.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image
image
image


Changelog

🆑
add: Added new smith role
add: Added smart hopper, magma crucible, power hammer, lava furnace, casting basin, and kinetic assembler machines
add: Suit inserts, tool bits, and energy gun lenses
add: Palladium, Platinum, and Iridium space ores
add: New branch of lavaland mining outpost: smithing workshop
add: Smith's office to all stations
add: New clothing for the smith role. Jumpsuit, jumpskirt, bomber, etc.
add: Hammer tool and tool_act
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map Sprites This PR modifies the game sprites labels Feb 6, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 6, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 6, 2025
@SynthTwo
Copy link
Contributor

SynthTwo commented Feb 6, 2025

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Feb 6, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Requested This PR has a pending testmerge request label Feb 6, 2025
@@ -7677,11 +8114,6 @@
/obj/machinery/alarm/directional/north,
/turf/simulated/floor/plasteel,
/area/mine/outpost/mechbay)
"Jn" = (
/obj/structure/lattice/catwalk/mining,
/mob/living/simple_animal/cockroach/brad,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest in peace, Brad. You deserved better.

@Fordoxia
Copy link
Contributor

Fordoxia commented Feb 8, 2025

MD is showing a very wide area for changes on EmeraldStation. Check you didn't accidentally edit a pre-existing object.

Poor Brad...

@PollardTheDragon
Copy link
Contributor Author

MD is showing a very wide area for changes on EmeraldStation. Check you didn't accidentally edit a pre-existing object.

Thanks for catching this. Yeah, I edited the RND button. Whoops!

I've fixed it. Dunno if it'll still appear on the MD.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Feb 9, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Map Edit This PR will modify a map Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants