[PERF] ConvertLegacyStoredDataObserver expensive query on sales_order table for ext_customer_id in (NULL)

[steven-hoffman-jomashop]

https://github.com/ParadoxLabs-Inc/authnetcim/blob/master/Observer/ConvertLegacyStoredDataObserver.php

🐢 Performance Issue

Current behavior

When ConvertLegacyStoredDataObserver triggers it can make a query like the following.
SELECT `main_table`.* FROM `sales_order` AS `main_table` WHERE (`ext_customer_id` IN(NULL))
This is clearly very expensive; in any case, unnecessary.

Expected behavior

Not make the query when the condition is NULL.
(Note this would be expensive if the condition is not null)

Minimal reproduction of the problem with instructions

• Trigger ConvertLegacyStoredDataObserver::execute
• Ensure that you react $cards = $this->getCardsFromProfile($profile);
• Ensure that $cards = $this->getCardsFromProfile($profile); is not empty
• Ensure that $this->convertCards unsets the cards
• Update orders is fired with an empty array (Leading to the null above)

What is the motivation / use case for changing the behavior?

• Increase performance in the simple case

Environment

• Should replicate in 5.1.2 as relevant code appears unchanged
• (It does seem that converting guests to customer is contributing as Car.php sets version 200, but customer may be a guest at that point)

[rhoerr]

Thanks @steven-hoffman-jomashop ! This should be fairly easy for us to check and fix. We'll short-circuit updateOrders() if $cards is empty.

[rhoerr]

Pushed a change that should resolve this. Will be included in our next release.