Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly querystring encode the parameters #1001

Merged
merged 2 commits into from
Mar 17, 2016
Merged

Properly querystring encode the parameters #1001

merged 2 commits into from
Mar 17, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #993

@codecov-io
Copy link

Current coverage is 91.61%

Merging #1001 into master will decrease coverage by -0.01% as of 429a857

@@            master   #1001   diff @@
======================================
  Files           73      73       
  Stmts         4432    4436     +4
  Branches       888     888       
  Methods          0       0       
======================================
+ Hit           4061    4064     +3
  Partial         10      10       
- Missed         361     362     +1

Review entire Coverage Diff as of 429a857

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Contributor

Can you add a test with the problematic username as well please?

@flovilmart flovilmart force-pushed the flovilmart.queryStringForEmailResets branch from ccc19ad to 0bd21cb Compare March 14, 2016 12:43
@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@facebook-github-bot
Copy link

@flovilmart updated the pull request.

@gfosco gfosco mentioned this pull request Mar 17, 2016
Closed
3 tasks
flovilmart added a commit that referenced this pull request Mar 17, 2016
@flovilmart
Merge pull request #1001 from ParsePlatform/flovilmart.queryStringFor…
5c8ad83 
…EmailResets

Properly querystring encode the parameters
@flovilmart flovilmart merged commit 5c8ad83 into master Mar 17, 2016
@flovilmart flovilmart deleted the flovilmart.queryStringForEmailResets branch March 17, 2016 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password reset link not working for usernames with "+"
5 participants
@flovilmart @codecov-io @drew-gross @facebook-github-bot @gfosco