Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures _auth_data_[provider] gets deleted from document #1081

Merged
merged 2 commits into from
Mar 17, 2016

Conversation

flovilmart
Copy link
Contributor

Before that PR, the auth_data{provider} would stay in the DB as = null, this proposed PR actually performs and $unset operation on the column to ensure a better consistency.

@flovilmart
Copy link
Contributor Author

@Scoup if you could try this branch and let me know if the bug keeps occurring

@codecov-io
Copy link

Current coverage is 86.12%

Merging #1081 into master will increase coverage by +0.01% as of 03dec25

@@            master   #1081   diff @@
======================================
  Files           76      76       
  Stmts         5100    5103     +3
  Branches      1107    1108     +1
  Methods          0       0       
======================================
+ Hit           4392    4395     +3
  Partial         13      13       
  Missed         695     695       

Review entire Coverage Diff as of 03dec25

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart force-pushed the flovilmart.deleteAuthData branch from 223041e to 5ff186f Compare March 17, 2016 20:35
flovilmart added a commit that referenced this pull request Mar 17, 2016
Ensures _auth_data_[provider] gets deleted from document
@flovilmart flovilmart merged commit e2bcc87 into master Mar 17, 2016
@flovilmart flovilmart deleted the flovilmart.deleteAuthData branch March 17, 2016 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants