Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with invalid email verification link on email update. #1253

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Fixed bug with invalid email verification link on email update. #1253

merged 1 commit into from
Mar 29, 2016

Conversation

kzielonka
Copy link
Contributor

I have found a bug with email verification link.
It works first time when user sign up but it sends 'undefined' token when user updates his email.
The verification link looks like:
parse/apps/rd11pKB86cuL59ApIUn1SfWhXyGYC6AqQS2EGk4T/verify_email?token=undefined&username=krzysztof.zielonka%40droidsonorids.pl
The problem is that in this case user is fetched before email is sent. The token which is stored in user Object is lost during fetch.

@codecov-io
Copy link

Current coverage is 93.04%

Merging #1253 into master will increase coverage by +0.02% as of da4cbd7

@@            master   #1253   diff @@
======================================
  Files           83      83       
  Stmts         5287    5289     +2
  Branches       965     965       
  Methods          0       0       
======================================
+ Hit           4918    4921     +3
  Partial         10      10       
+ Missed         359     358     -1

Review entire Coverage Diff as of da4cbd7

Powered by Codecov. Updated on successful CI builds.

@flovilmart
Copy link
Contributor

Could you squash it all in 1 commit please?

@kzielonka
Copy link
Contributor Author

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants