Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds relation fields to objects #1424

Merged
merged 1 commit into from
Apr 8, 2016
Merged

Adds relation fields to objects #1424

merged 1 commit into from
Apr 8, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1311
may fix #1112

@codecov-io
Copy link

Current coverage is 92.80%

Merging #1424 into master will not affect coverage as of 75a4ca5

@@            master   #1424   diff @@
======================================
  Files           86      86       
  Stmts         5449    5460    +11
  Branches      1005    1007     +2
  Methods          0       0       
======================================
+ Hit           5057    5067    +10
  Partial         10      10       
- Missed         382     383     +1

Review entire Coverage Diff as of 75a4ca5

Powered by Codecov. Updated on successful CI builds.

drew-gross
drew-gross reviewed Apr 8, 2016
View reviewed changes
spec/transform.spec.js
@@ -13,6 +13,9 @@ var dummySchema = {
return 'geopoint';
}
return;
},
getRelationFields: function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you leave this in by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we need it on the dummy schema otherwise the function is missing when running the tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK.

@flovilmart flovilmart merged commit a770c4c into master Apr 8, 2016
@drew-gross drew-gross deleted the fix-missing-relation branch April 8, 2016 16:30
@snyk-bot snyk-bot mentioned this pull request Nov 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drew-gross drew-gross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relation fields is not retrieved Called relation() on non-relation field even when field is relation.
4 participants
@flovilmart @codecov-io @drew-gross @facebook-github-bot