Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mongo field type logic into mongoadapter #1432

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

drew-gross
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 92.77%

Merging #1432 into master will decrease coverage by -0.02% as of 1e92aa6

@@            master   #1432   diff @@
======================================
  Files           87      87       
  Stmts         5485    5480     -5
  Branches      1013    1010     -3
  Methods          0       0       
======================================
- Hit           5090    5084     -6
  Partial         10      10       
- Missed         385     386     +1

Review entire Coverage Diff as of 1e92aa6

Powered by Codecov. Updated on successful CI builds.

@facebook-github-bot
Copy link

@drew-gross updated the pull request.

var found = false;
for (var i = 0; i < aclGroup.length && !found; i++) {
let found = false;
for (let i = 0; i < aclGroup.length && !found; i++) {
if (perms[aclGroup[i]]) {
found = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird to me to see the loop breaking it in the if statement, especially since you are doing a additional if for every iteration of the loop.

could this not just be done as the standard

if ( .. ) {
  found = true; 
  break;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even better: use Array.prototype.some. But I'd rather do that in a different PR.

@flovilmart
Copy link
Contributor

LGTM.

@flovilmart flovilmart merged commit 99ecbb3 into parse-community:master Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants