Remove collection prefix and default mongo URI #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 529d67d.
|
It starts being so beautiful @drew-gross ! |
| return database.adaptiveCollection(className).then(collection => { | ||
| return database.adapter.deleteFields(className, [fieldName], [], database.collectionPrefix, collection); | ||
| }) | ||
| return database.adapter.deleteFields(className, [fieldName], []) |
There was a problem hiding this comment.
can we expose the deleteFields on the dbController just so we don't call adapter here?
There was a problem hiding this comment.
I don't really see the point of having a super thin extra dbController layer that just calls into some other function.
There was a problem hiding this comment.
Just to hide the internals as they are pretty much hidden everywhere else. but that's ok
|
Just one tiny suggestion, let me know if you wanna do it, otherwise I'll merge. |
Current coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the collection prefix and default mongo URI from DatabaseAdapter.
The DefaultMongoURI is now duplicated across the MongoAdapter and GridStore but those are separate adapters that will eventually be in separate repos, so it makes sense for them to be duplicated.