Fix delete relation field when _Join collection not exist #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
Nice... Thanks! 👍 |
gfosco
added a commit
that referenced
this pull request
Mar 6, 2016
Fix delete relation field when _Join collection not exist
| @@ -409,7 +409,11 @@ class Schema { | |||
|
|
|||
| if (this.data[className][fieldName].startsWith('relation<')) { | |||
| //For relations, drop the _Join table | |||
| return database.dropCollection(`_Join:${fieldName}:${className}`); | |||
| return database.collectionExists(`_Join:${fieldName}:${className}`).then(exist => { | |||
There was a problem hiding this comment.
@Marco129 This is slightly racy. I don't expect people to be have many callers attempting to create and delete the same field many times, but I'd rather just avoid race conditions everywhere. Can you modify this to attempt the delete, and catch the error if the collection doesn't exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #848
Check for existence before dropping