Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the exception related headers be represented by FaultsHeaderKeys? #6872

Closed
SeanFeldman opened this issue Oct 2, 2023 · 4 comments
Closed

Should the exception related headers be represented by FaultsHeaderKeys? #6872

SeanFeldman opened this issue Oct 2, 2023 · 4 comments
Labels
Improvement

Comments

@SeanFeldman
Copy link
Contributor

Describe the suggested improvement

Is your improvement related to a problem? Please describe.

Every failed message has the following headers.

FailedQ
NServiceBus.ExceptionInfo.ExceptionType
NServiceBus.ExceptionInfo.HelpLink
NServiceBus.ExceptionInfo.Message
NServiceBus.ExceptionInfo.Source
NServiceBus.ExceptionInfo.StackTrace

But FailedQ is the only header represented by FaultsHeaderKeys. Should the rest of the keys be added to FaultsHeaderKeys?

Additional Context

No response
@adamralph
Copy link
Member

Thank you for putting this on our radar @SeanFeldman.

@danielmarbach danielmarbach mentioned this issue Oct 4, 2023
Merged
@danielmarbach
Copy link
Contributor

@SeanFeldman is this what you had in mind? #6876

Do you see any value in exposing ExceptionInfoData prefix publicly?

@SeanFeldman
Copy link
Contributor Author

Exactly that, @danielmarbach.

Do you see any value in exposing ExceptionInfoData prefix publicly?

Not for what I'm doing 🙂

@danielmarbach
Copy link
Contributor

Addressed by #6876. Closing

@danielmarbach danielmarbach added this to the 9.0.0 milestone Oct 31, 2023
@bording bording removed this from the 9.0.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@danielmarbach @adamralph @bording @SeanFeldman