Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store all constants in one file #385

Closed
denispapakul opened this issue Apr 7, 2020 · 3 comments · Fixed by #393
Closed

Store all constants in one file #385

denispapakul opened this issue Apr 7, 2020 · 3 comments · Fixed by #393
Assignees

Comments

@denispapakul
Copy link
Contributor

I suggest storing all constants in one file in order to avoid code repetition and to use re-use of variables. This problem looks like this -
Screen Shot 2020-04-08 at 12 57 00 AM
Can implement it.

@tremblerz
Copy link
Contributor

Do you want to take it on? We'll assign it you

@denispapakul
Copy link
Contributor Author

Sure, yes, I will implement it.

@jpomazal
Copy link

jpomazal commented Apr 8, 2020

Just a comment on this, width isn't inherently a constant. If screen orientation changes, or if app goes side-by-side, etc. that could change.

To make it more compatible we should probably use a HOC, library or similar where needed and pull references to width out of static styles and change to style={[style.baseStyle,{width:...]} where needed, although we might want to consider removing static references in general and use alternative layout strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants