Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Feature request: Don't download Java when running the NPM artifact #14

Open
ZacSweers opened this issue Dec 18, 2022 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@ZacSweers
Copy link

Even if I run with JAVA_HOME pointed at a java 11 installation, it still tries to download one on the fly.

$ composeReport2Html -app STAR -overallStatsReport samples/star/build/compose_metrics/star_release-module.json -detailedStatsMetrics samples/star/build/compose_metrics/star_release-composables.csv -composableMetrics samples/star/build/compose_metrics/star_release-composables.txt -classMetrics samples/star/build/compose_metrics/star_release-classes.txt -o tmp
Downloading java runtime environment for version 11
@PatilShreyas
Copy link
Owner

@ZacSweers I'm not sure but I guess this issue is related to jdeploy. I'm also looking if how can we remove dependency on jdeploy and publish CLI independent of it.

@ZacSweers
Copy link
Author

Yeah it's due to jdeploy

@PatilShreyas PatilShreyas added the help wanted Extra attention is needed label Jan 21, 2023
@PatilShreyas
Copy link
Owner

Need help here regarding publishing this CLI without jdeploy!

@shnaseri
Copy link

any update?

@PatilShreyas
Copy link
Owner

For CLI, I'm still struggling to find alternatives to jdeploy. But the good news is I'm working on the gradle plugin, so that we don't need to use CLI

@PatilShreyas
Copy link
Owner

@ZacSweers I'm not sure but I guess this issue is related to jdeploy. I'm also looking if how can we remove dependency on jdeploy and publish CLI independent of it.

@ZacSweers exact issue isn't solved yet. But we have published a gradle plugin which does the report generation work automatically. This can help you to be independent from jdeploy.

Gradle plugin usage: https://patilshreyas.github.io/compose-report-to-html/use/using-gradle-plugin/

@PatilShreyas PatilShreyas changed the title Feature request: Don't download Java when running the NPM artifact [CLI] Feature request: Don't download Java when running the NPM artifact Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants