Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tune pid without redeploying #140

Merged
merged 7 commits into from
Feb 11, 2024
Merged

Tune pid without redeploying #140

merged 7 commits into from
Feb 11, 2024

Conversation

RudyG252
Copy link
Contributor

@RudyG252 RudyG252 commented Feb 6, 2024

No description provided.

Jacob1010-h
Jacob1010-h reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@Jacob1010-h Jacob1010-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently in progress :) keep at it

src/main/java/frc/robot/util/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/PIDNotConstants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/PIDTunerCommands.java Show resolved Hide resolved
src/main/java/frc/robot/util/PIDTunerCommands.java Outdated Show resolved Hide resolved
Jacob1010-h
Jacob1010-h requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Jacob1010-h Jacob1010-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure u like finish the file bro

@Jacob1010-h Jacob1010-h changed the base branch from 131-calibrate-the-shooter-pivot-speeds-etc-without-redeploying to calibration-control February 6, 2024 22:05
@RudyG252
fixed bugs. It works now but getting a lot of loop overruns for some …
1389aa8 
…reason, which might be a problem or might be my computer tweaking.
Jacob1010-h
Jacob1010-h approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Jacob1010-h Jacob1010-h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks mostly good, as long as it was tested

src/main/java/frc/robot/util/Constants.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/PIDTunerCommands.java Show resolved Hide resolved
@Jacob1010-h Jacob1010-h merged commit 50afcda into calibration-control Feb 11, 2024
@Jacob1010-h Jacob1010-h deleted the Tune-PID-Without-Redeploying branch February 11, 2024 05:57
@Jacob1010-h Jacob1010-h linked an issue Feb 11, 2024 that may be closed by this pull request
A way to tune PID without redeploying #132
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 left review comments

@Jacob1010-h Jacob1010-h Jacob1010-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A way to tune PID without redeploying
3 participants
@RudyG252 @GalexY727 @Jacob1010-h