142 calibration of speeds inside of sim #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Hamilton <GalexY727@users.noreply.github.com>
me when 120 mph at center line by scoring table :)
Closed
2 tasks
also rotate the speaker position to be a bit more normal
Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com> Co-authored-by: Jacob Hotz <77470805+Jacob1010-h@users.noreply.github.com> Co-authored-by: Rudy Good <122180943+RudyG252@users.noreply.github.com>
GalexY727
requested changes
Feb 8, 2024
|
ONE MORE REVIEW @GalexY727 |
…hub.com/Patribots4738/Crescendo2024 into 142-calibration-of-speeds-inside-of-sim
|
Oh shoot. I forgot about our usage of gravity being positive for the square roots. Shoooot. Can you undo that change? I would add the units of gravity though so that it's known that it's meters per second. Sorry about that 😔 |
|
Feel free to merge in with 6298e93 once units are added |
Jacob1010-h
commented
Feb 9, 2024
sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much review should need to be done but I thought I should make this :DD