generated from Patribots4738/Swerve-Command-Based
-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sim dev -> main (🎶one last time🎶) #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Rudy Good <122180943+RudyG252@users.noreply.github.com>
Co-authored-by: Tina H <derp00monsta@users.noreply.github.com>
…s odometry if it gets out of hand
…er.set so we can cache the desired speed
…thPlannerStorage +... fix issue where AutoConstants was generating paths before NamedCommands were registering move swerve's field2d to robotContainer simplify some logic in other files oh and purge some imports
GalexY727
changed the title
Sim dev -> main (🎶 one last time 🎶)
Sim dev -> main (🎶one last time🎶)
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. There is one comment about your comments btw. This is the biggest pr I've reviewed so thank you 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be the final (probably) PR from sim-dev and will result in sim-dev's deletion for the rest of the foreseeable future. Of the time that this PR has been made, it includes everything from 2/19 and will be a nice way to close this branch finally.