Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim dev -> main (🎶one last time🎶) #172

Merged
merged 38 commits into from
Feb 22, 2024
Merged

Sim dev -> main (🎶one last time🎶) #172

merged 38 commits into from
Feb 22, 2024

Conversation

Jacob1010-h
Copy link
Member

This will be the final (probably) PR from sim-dev and will result in sim-dev's deletion for the rest of the foreseeable future. Of the time that this PR has been made, it includes everything from 2/19 and will be a nice way to close this branch finally.

Oliver-Cushman and others added 5 commits February 20, 2024 13:23
…thPlannerStorage +...

fix issue where AutoConstants was generating paths before NamedCommands were registering
move swerve's field2d to robotContainer
simplify some logic in other files
oh and purge some imports
@GalexY727 GalexY727 changed the title Sim dev Sim dev -> main (🎶 one last time 🎶) Feb 21, 2024
@GalexY727 GalexY727 changed the title Sim dev -> main (🎶 one last time 🎶) Sim dev -> main (🎶one last time🎶) Feb 21, 2024
Copy link
Contributor

@derp00monsta derp00monsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. There is one comment about your comments btw. This is the biggest pr I've reviewed so thank you 😭

src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
@Jacob1010-h Jacob1010-h merged commit d0fe0cd into main Feb 22, 2024
1 check passed
@Jacob1010-h Jacob1010-h deleted the sim-dev branch February 22, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants