Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End traj pathplan #175

Merged
merged 6 commits into from
Feb 21, 2024
Merged

End traj pathplan #175

merged 6 commits into from
Feb 21, 2024

Conversation

Jacob1010-h
Copy link
Member

This should be ready! minus a few logs ofc

@Jacob1010-h Jacob1010-h added enhancement New feature or request autonomous Something that needs to get done for the Autonomous period of the match ready to test Ready to test on the robot :> command A command on the robot that controls a subsystem labels Feb 21, 2024
@Jacob1010-h Jacob1010-h added this to the Autonomous milestone Feb 21, 2024
@Jacob1010-h Jacob1010-h self-assigned this Feb 21, 2024
@Jacob1010-h Jacob1010-h linked an issue Feb 21, 2024 that may be closed by this pull request
Get Last Pose in Active Trejectory and View Active Path #174
Closed
@Jacob1010-h
Copy link
Member Author

resolved merge conflicts (imports)

@GalexY727
Refactor trajectory visualization to be contained mostly inside of Pa…
3e21cc6 
…thPlannerStorage +...

fix issue where AutoConstants was generating paths before NamedCommands were registering
move swerve's field2d to robotContainer
simplify some logic in other files
oh and purge some imports
GalexY727
GalexY727 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Consider adding docs but surely that'll be a health and wellness for another time.

src/main/java/frc/robot/commands/autonomous/PathPlannerStorage.java Show resolved Hide resolved
src/main/java/frc/robot/util/PatriSendableChooser.java Show resolved Hide resolved
@GalexY727 GalexY727 merged commit e663e39 into sim-dev Feb 21, 2024
@GalexY727 GalexY727 deleted the end-traj-pathplan branch February 21, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 approved these changes

Assignees

@Jacob1010-h Jacob1010-h

Labels
autonomous Something that needs to get done for the Autonomous period of the match command A command on the robot that controls a subsystem enhancement New feature or request ready to test Ready to test on the robot :>
Projects
None yet
Milestone
Autonomous
Development

Successfully merging this pull request may close these issues.

Get Last Pose in Active Trejectory and View Active Path
2 participants
@Jacob1010-h @GalexY727