Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why hmr and other are added to dependencies when they are not required in production #1234

Closed
thekalinga opened this issue Dec 2, 2016 · 0 comments

Comments

@thekalinga
Copy link

Note: for support questions, please use one of these channels: Chat: AngularClass.slack or Twitter: @AngularClass

  • I'm submitting a ...
    [ ] bug report
    [ ] feature request
    [ x ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug?

  • What is the current behavior?

Why are the the following libraries added to dependencies section instead of devDependencies section, as hot module reloading functionality is not required in production.

"@angularclass/conventions-loader": "^1.0.2",
"@angularclass/hmr": "~1.2.2",
"@angularclass/hmr-loader": "~3.0.2",
"assets-webpack-plugin": "^3.4.0",

These dependencies should be part of devDependencies

  • What is the motivation / use case for changing the behavior?

  • Please tell us about your environment:

  • Angular version: 2.0.0-beta.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
@thekalinga thekalinga changed the title Why hmr and other are added to dev dependencies when they are not required at runtime in production Why hmr and other are added to dev dependencies when they are not required in production Dec 2, 2016
@thekalinga thekalinga changed the title Why hmr and other are added to dev dependencies when they are not required in production Why hmr and other are added to dependencies when they are not required in production Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants