Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest.json #192

Closed
vladotesanovic opened this issue Jan 4, 2016 · 2 comments
Closed

manifest.json #192

vladotesanovic opened this issue Jan 4, 2016 · 2 comments

Comments

@vladotesanovic
Copy link
Contributor

In this file:
https://github.com/AngularClass/angular2-webpack-starter/blob/master/src/assets/manifest.json

Google chrome 47 ( tested on Ubuntu ) expect float instead of string in density key.

This is ok:

{
 "name": "App",
 "icons": [
  {
   "src": "/assets/icon/android-icon-36x36.png",
   "sizes": "36x36",
   "type": "image/png",
   "density": 0.75
  },
  {
   "src": "/assets/icon/android-icon-48x48.png",
   "sizes": "48x48",
   "type": "image/png",
   "density": 1.0
  },
  {
   "src": "/assets/icon/android-icon-72x72.png",
   "sizes": "72x72",
   "type": "image/png",
   "density": 1.5
  },
  {
   "src": "/assets/icon/android-icon-96x96.png",
   "sizes": "96x96",
   "type": "image/png",
   "density": 2.0
  },
  {
   "src": "/assets/icon/android-icon-144x144.png",
   "sizes": "144x144",
   "type": "image/png",
   "density": 3.0
  },
  {
   "src": "/assets/icon/android-icon-192x192.png",
   "sizes": "192x192",
   "type": "image/png",
   "density": 4.0
  }
 ]
}
@PatrickJS
Copy link
Owner

can you make a pull-request so I can merge it?

@vladotesanovic
Copy link
Contributor Author

yes, i did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants