remappings.txt src/ entry causes problems

[aathan]

I'm not sure why the src/=src/ entry in remappings.txt is necessary. However, it currently causes problems when prb-contracts is used a lib/ component in a foundry project, because any imports in the main project tend to resolve to relative-from-base-of-project paths that start with src/ and for whatever reason, foundry's invocation of solc must incorporate the remappings.txt of prb-contracts in such a way that this ends up now attempting to import from prb-contracts. I've reported this to the foundry project, and the "right" solution may end up being that they need to translate the remappings.txt of dependencies before using those to build the solc remappings; or, perhaps this problematic entry can be removed from your project? Removing it manually after the git submodule fetch seems to work ok FYI.

[PaulRBerg]

This is a known bug in Foundry: foundry-rs/foundry#3440

It's not that it's necessary (forge build and forge test work without it), but that adding it makes VSCode's Go to Definition work. So it's unfortunate that projects like PRBContracts cannot use the src/=src/ remapping because of this bug.

Anyway, I agree that it makes sense to remove src/=src/ from this repo's remappings for now.

[PaulRBerg]

Fixed via #41, and v5.0.5.