Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current sanitization of fill color prevents no-comma function syntax from working #17

Open
dotterian opened this issue Feb 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@dotterian
Copy link

dotterian commented Feb 25, 2023

No-comma color functions syntax is valid CSS, is supported by all major browsers and used by me in production:

color: rgb(255 255 255/.5); /* Semi-transparent white */

But with current parameter sanitization it transforms into unparseable mess:

--squircle-fill: rgb(255255255/.5); /* Weird $#!7 */

This raises a question:
What was the reason of adding .replace(/\s/g, "")?
Can we safely remove it or replace it with something more refined, so we can keep no-comma syntax intact?

@PavelLaptev
Copy link
Owner

Thank you @chrisyalamov for contributing 🙏 I'll add this into the next release

@PavelLaptev PavelLaptev added the bug Something isn't working label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants