You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are cases where Libxlsxwriter returns a NULL pointer intentionally (rather than because of a memory error).
In those cases, I think FastExcel should return nil instead of a Struct of null pointer, especially because further usage on the Struct is likely to yield segmentation fault error and crashes the whole process (rather than just a Ruby RuntimeError when using nil values improperly).
For example:
WorkbookWrappers#get_worksheet_by_name when worksheet is not found
WorkbookWrappers#default_format when there are no formats?
WorksheetWrappers#find_row when row is not found?
The text was updated successfully, but these errors were encountered:
See Note number 1 of #83.
There are cases where Libxlsxwriter returns a NULL pointer intentionally (rather than because of a memory error).
In those cases, I think FastExcel should return
nil
instead of a Struct of null pointer, especially because further usage on the Struct is likely to yield segmentation fault error and crashes the whole process (rather than just a Ruby RuntimeError when using nil values improperly).For example:
WorkbookWrappers#get_worksheet_by_name
when worksheet is not foundWorkbookWrappers#default_format
when there are no formats?WorksheetWrappers#find_row
when row is not found?The text was updated successfully, but these errors were encountered: