Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CaptureController::doSessionTokenAction should forward request data #427

Open
Tetragramat opened this issue Jul 26, 2017 · 7 comments
Open
Labels

Comments

@Tetragramat
Copy link
Contributor

If user is redirected from payment gateway with post or query data, then all values are discarded with redirect to the CaptureController::doAction.

This would be usefull because some payment gateways does not support dynamic return url.

@makasim
Copy link
Member

makasim commented Jul 26, 2017

I'd say the gateway have to store all data required (including one from request's query) before redirecting to doAction

@Tetragramat
Copy link
Contributor Author

I agree, it is better than forwarding those data. Where it should be stored? In session or in payment model? Gateway is not loaded in doSessionTokenAction.

@makasim
Copy link
Member

makasim commented Jul 26, 2017

It is supposed to be stored in payment model and persisted by storage (with a help of storage extension).

@Tetragramat
Copy link
Contributor Author

So does that mean that there in doSessionTokenAction should be executed some request on gateway which will store values in payment model and store extension will persist it?

@makasim
Copy link
Member

makasim commented Jul 26, 2017

Sorry I thought the controller called a payum gateway. But it is not.

The request has to be proxied with all possible data indeed. and I think if the original request is not GET we have to do a post redirect.

@Tetragramat
Copy link
Contributor Author

Tetragramat commented Jul 26, 2017

By "payment gateways" in OP i meant something like Paypal/Stripe/Klarna. In this case is it something like Payeezy/First Data - FIO Banka scheme (it is unclear what is it's real name).

So, when it is clear now. Will be this feature in PayumBundle? I'm not sure If I will be able to efectively do proxy request.

@makasim
Copy link
Member

makasim commented Jul 26, 2017

I don't have time to implement it myself though maybe some one else pick this up and do a PR>

@makasim makasim added the bug label Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants