Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Potential issue? calling a kick on a name on an stolen/impossible name #40

Open
surepy opened this issue Jun 5, 2020 · 3 comments
Open
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement New feature or request

Comments

@surepy
Copy link

surepy commented Jun 5, 2020

Can't really check right now. but the message
Attention! There is a cheater on the other team named %s. Please kick them!
can pretty sure cause potential issues if the name is stolen, involves newline, etc. might want to change it to

Attention! There is a cheater on the other team named %s [id: (steamid)]. Please kick them!
or craft another chat message after the current message with steamid like
[TF2BD] Votekick id: steamid for example.

@surepy
Copy link
Author

surepy commented Jun 6, 2020

Ideally, you'd want to use the userid as that's what you use to votekick in console.

yes, and using names on chat to communicate between TF2BD clients may cause potential issues and is the reason why I opened this issue.

@ClusterConsultant ClusterConsultant added Priority: Medium This issue may be useful, and needs some attention. Type: Enhancement New feature or request labels Jul 2, 2020
@ClusterConsultant
Copy link
Collaborator

Related to #70

@PazerOP PazerOP added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix and removed Priority: Medium This issue may be useful, and needs some attention. labels Jul 27, 2020
@ClusterConsultant
Copy link
Collaborator

If/when #70 comes about this will probably be closed since there wont be a ton of purpose to uber robust built in messages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@PazerOP @ClusterConsultant @surepy and others