Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rework contentHeights to use a shared value #146

Merged
merged 2 commits into from
Feb 25, 2021
Merged

fix: rework contentHeights to use a shared value #146

merged 2 commits into from
Feb 25, 2021

Conversation

andreialecu
Copy link
Collaborator

Fixes #145

@andreialecu
Copy link
Collaborator Author

@alexpchin please give this a try:

react-native-collapsible-tab-view-v4.0.0.tgz.zip

@andreialecu andreialecu mentioned this pull request Feb 25, 2021
Closed
@alexpchin
Copy link
Contributor

Thanks for the assist @andreialecu I'll just installed it seems to fix the issue.

Just a note, I was previously on ^4.0.0-rc.11 so this zip broke my CenteredEmptyList implementation (as per the example code) as useTabsContext is not exported. I can update to useHeaderMeasurements but the example will need to be updated too I believe?

@andreialecu
Copy link
Collaborator Author

Fixed the example in 9419228 (#146)

@andreialecu andreialecu merged commit 0cecd27 into main Feb 25, 2021
@andreialecu andreialecu deleted the aa/fix-contentheights branch February 25, 2021 14:01
@andreialecu
Copy link
Collaborator Author

Released as 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content jumping as you scroll down
2 participants
@andreialecu @alexpchin