-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SectionList support (without stickyHeaders for now) #201
Conversation
removed disabled stickySectionHeaders to be in line with FlatLists approach to stickyHeaders issue
I initially wanted to create a seperate pull request for the reanimated and Expo update, but it looks like I added the commit to this pull request. Sorry, I´m still a bit new to git. Anyway, this pr would close this issue: #164 |
hi @alexco2 thanks for the PR, appreciate the bump on expo and reanimated 🙌 But it has a bug (don't know if there are more bugs though, I stopped testing after this due to time constraints on my end): bug.mp4 |
Hi @PedroBern |
@alexco2 with the required review changes looks good to me 🚀 thanks for the PR 🎉 @andreialecu could you please review as well? |
I'll take a look tomorrow. |
Released in 4.3.0 🚀 |
@PedroBern @andreialecu |
Thank you @alexco2, keep 'em coming! 💯 |
Added SectionList Support. Also updated documentation and added example tab with a SectionList.
As we know from #136 stickyHeaders cause a problem. This issue also applies to SectionList. I played around with paddingTop, but couldn´t solve the issue.
I also upgraded Expo to v42 and reanimated to v2.2.2.