Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll on Header not scrolling other tabs (iOS) #66

Closed
andreialecu opened this issue Jan 30, 2021 · 5 comments · Fixed by #76
Closed

Scroll on Header not scrolling other tabs (iOS) #66

andreialecu opened this issue Jan 30, 2021 · 5 comments · Fixed by #76
Assignees
Labels
bug Something isn't working

Comments

@andreialecu
Copy link
Collaborator

Current behavior

In the scroll on header example, if I go to contacts and scroll to the end, then tap the status bar, it correctly scrolls the current tab to the top.

However, all the other tabs are not synced.

Expected behaviour

All tabs should be scrolled to the top.

Screenshots (if applicable)

IMG_E4F8296E5D88-1

@andreialecu andreialecu added the bug Something isn't working label Jan 30, 2021
@PedroBern
Copy link
Owner

PedroBern commented Jan 30, 2021

... then tap the status bar ...

Do you mean the status bar or the tab bar? Maybe it's not syncing when tapping on the status bar, not sure how can I solve this...

Is it only in this example?

@andreialecu
Copy link
Collaborator Author

Oh, interesting. I didn't know it meant tapping the tab bar.

On iOS the native way to scroll to the top is by tapping the top status bar of the phone (where the time and battery are displayed)

Is likely easy to hook into and detect. I'll look into it tomorrow.

@andreialecu
Copy link
Collaborator Author

@PedroBern
Copy link
Owner

ok, perfect, should be easy to fix then 👍

@andreialecu
Copy link
Collaborator Author

So actually I don't think the right fix is to handle that event.

The normal onScroll event is fired when scrolling to the top, but because the gesture is not started by onBeginDrag, sync ends up being false:

return !isSnapping.value && !isScrolling.value && !isGliding.value
},
(sync) => {
if (sync && focusedTab.value !== name) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants