-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with react navigation #7
Comments
Hi @andreialecu, I don't plan to add the integration by myself, because for now it solves my use case. But if you or someone is willing to open a PR, I would accept it :) ImplementationThe implementation is super simple, you can do it in 3 steps: 1. MaterialTopTabsCollapsibleTabViewSame as the original, replacing the 2. MaterialTopTabsCollapsibleNavigatorJust like in step 1, same as the original, replacing the 3. Changes in the CollapsibleTabViewThere is this one caveat, currently, the --- activeRouteKey: routes[index].key,
+++ activeRouteKey: routes[index].name, InvestigationI'm not using it and it may have bugs, especially for the snap effect. Please if you can fork, experiment and maybe find ways to improve, would be really nice :) |
merged #10 👍 |
released in v1.2.0 |
Thank you for creating this!
I saw that you mentioned in satya164/react-native-tab-view#1096 (comment) that there would be integration with
react-navigation
.I'm really interested in this, and would love to help by testing it. Alternatively, if you can share the private implementation you mentioned, I might be able to implement and test that as well, before a polished public release.
The text was updated successfully, but these errors were encountered: