You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
haoming29 opened this issue
Jun 21, 2024
· 0 comments
· Fixed by #1451
Labels
bugSomething isn't workingcacheIssue relating to the cache componentcriticalHigh priority for next releasedirectorIssue relating to the director componentoriginIssue relating to the origin componentregistryIssue relating to the registry component
As Fabio reported, when setting the Server.TLSCACertificateDirectory config via environment variable, i.e. PELICAN_SERVER_TLSCACERTIFICATEDIRECTORY=/etc/grid-security/certificates, the value isn't propagated to xrootd config. This is because we used viper.Unmarshal to unmarshal viper configuration to our defined xrootd configuration struct:
return"", errors.Wrap(err, "failed to unmarshal xrootd config")
}
However, given the bug in viper, the values of nested fields are lost in unmarshaling. People in the the referred issue proposed a couple of work-around and we should pick one and replace all our instances where we used viper.Unmarshal.
The text was updated successfully, but these errors were encountered:
haoming29
added
bug
Something isn't working
critical
High priority for next release
cache
Issue relating to the cache component
origin
Issue relating to the origin component
director
Issue relating to the director component
registry
Issue relating to the registry component
labels
Jun 21, 2024
bugSomething isn't workingcacheIssue relating to the cache componentcriticalHigh priority for next releasedirectorIssue relating to the director componentoriginIssue relating to the origin componentregistryIssue relating to the registry component
Ref: spf13/viper#761
As Fabio reported, when setting the
Server.TLSCACertificateDirectory
config via environment variable, i.e.PELICAN_SERVER_TLSCACERTIFICATEDIRECTORY=/etc/grid-security/certificates
, the value isn't propagated to xrootd config. This is because we usedviper.Unmarshal
to unmarshal viper configuration to our defined xrootd configuration struct:pelican/xrootd/xrootd_config.go
Lines 680 to 682 in b269e79
However, given the bug in viper, the values of nested fields are lost in unmarshaling. People in the the referred issue proposed a couple of work-around and we should pick one and replace all our instances where we used
viper.Unmarshal
.The text was updated successfully, but these errors were encountered: