Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRUB limited by chi-squared values to scans with <= 100 control-label pairs #394

Open
tsalo opened this issue Mar 18, 2024 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@tsalo
Copy link
Member

tsalo commented Mar 18, 2024

Summary

The function _getchisquare relies on hardcoded chi-squared values, which only go up to 100 dof, which means that any scans with more than that number of control-label pairs will raise an error.

I recall trying out different settings in scipy.stats.chi2 calls before, but not being able to figure out where these specific chi-squared values come from, so I need to ask Sudipto Dolui for help.

This stems from https://neurostars.org/t/aslprep-basil-doesnt-work/28631.

Additional details

  • ASLPrep version: 0.6.0
  • Docker version:
  • Singularity version:

What were you trying to do?

Run ASLPrep with scorescrub enabled on dat awith 135 control-label pairs.

What did you expect to happen?

What actually happened?

Traceback:
	Traceback (most recent call last):
	  File "/usr/local/miniconda/lib/python3.9/site-packages/nipype/interfaces/base/core.py", line 397, in run
	    runtime = self._run_interface(runtime)
	  File "/usr/local/miniconda/lib/python3.9/site-packages/aslprep/interfaces/cbf.py", line 745, in _run_interface
	    cbfscrub = _scrubcbf(
	  File "/usr/local/miniconda/lib/python3.9/site-packages/aslprep/utils/cbf.py", line 439, in _scrubcbf
	    thresh1, thresh3 = _getchisquare(y.shape[0])
	  File "/usr/local/miniconda/lib/python3.9/site-packages/aslprep/utils/cbf.py", line 273, in _getchisquare
	    return a[n - 1], b[n - 1]
	IndexError: list index out of range
@tsalo tsalo added the bug Something isn't working label Mar 18, 2024
@tsalo tsalo self-assigned this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant